netdev - Re: [PATCH v11 02/25] net/ethtool: add new stringset ETH_SS_ULP_DDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230203194259.67c08c7a@kernel.org>
Date:   Fri, 3 Feb 2023 19:42:59 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Aurelien Aptel <aaptel@...dia.com>
Cc:     linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
        sagi@...mberg.me, hch@....de, kbusch@...nel.org, axboe@...com,
        chaitanyak@...dia.com, davem@...emloft.net,
        aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
        ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com
Subject: Re: [PATCH v11 02/25] net/ethtool: add new stringset
 ETH_SS_ULP_DDP_{CAPS,STATS}

On Fri,  3 Feb 2023 15:26:42 +0200 Aurelien Aptel wrote:
> This commit exposes ULP DDP capability and statistics names to
> userspace via netlink.
> 
> In order to support future ULP DDP capabilities and statistics without
> having to change the netlink protocol (and userspace ethtool) we add
> new string sets to let userspace dynamically fetch what the kernel
> supports.
> 
> * ETH_SS_ULP_DDP_CAPS stores names of ULP DDP capabilities
> * ETH_SS_ULP_DDP_STATS stores names of ULP DDP statistics.
> 
> These stringsets will be used in later commits when implementing the
> new ULP DDP GET/SET netlink messages.
> 
> We keep the convention of strset.c of having the static_assert()
> right after the array declaration, despite the checkpatch warning.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>