[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66a5d1bc-2220-4298-b166-b41f17508599@gmail.com>
Date: Mon, 6 Feb 2023 12:00:29 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: alejandro.lucero-palau@....com, netdev@...r.kernel.org,
linux-net-drivers@....com
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
edumazet@...gle.com, habetsm.xilinx@...il.com,
linux-doc@...r.kernel.org, corbet@....net, jiri@...dia.com
Subject: Re: [PATCH v5 net-next 1/8] sfc: add devlink support for ef100
On 02/02/2023 11:14, alejandro.lucero-palau@....com wrote:
> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>
> Basic devlink infrastructure support.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@....com>
...
> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> new file mode 100644
> index 000000000000..933e60876a93
> --- /dev/null
> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> @@ -0,0 +1,71 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/****************************************************************************
> + * Driver for AMD network controllers and boards
> + * Copyright (C) 2023, Advanced Micro Devices, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published
> + * by the Free Software Foundation, incorporated herein by reference.
> + */
> +
> +#include <linux/rtc.h>
> +#include "net_driver.h"
> +#include "ef100_nic.h"
> +#include "efx_devlink.h"
> +#include "nic.h"
> +#include "mcdi.h"
> +#include "mcdi_functions.h"
> +#include "mcdi_pcol.h"
nit: as far as I can tell, most of these includes aren't used until
the next patch (rtc, mcdi*, possibly *nic too) and should thus only
be added there. If you're respinning anyway, may as well fix it.
Powered by blists - more mailing lists