netdev - Re: [PATCH net-next] ethtool: mm: fix get_mm() return code not propagating to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+Dtsn1bXTlu8cYR@corigine.com>
Date:   Mon, 6 Feb 2023 13:08:18 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH net-next] ethtool: mm: fix get_mm() return code not
 propagating to user space

On Mon, Feb 06, 2023 at 11:49:32AM +0200, Vladimir Oltean wrote:
> If ops->get_mm() returns a non-zero error code, we goto out_complete,
> but there, we return 0. Fix that to propagate the "ret" variable to the
> caller. If ops->get_mm() succeeds, it will always return 0.
> 
> Fixes: 2b30f8291a30 ("net: ethtool: add support for MAC Merge layer")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>