lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y+EBArQ5JP5bRZpc@lunn.ch> Date: Mon, 6 Feb 2023 14:30:42 +0100 From: Andrew Lunn <andrew@...n.ch> To: Horatiu Vultur <horatiu.vultur@...rochip.com> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, michael@...le.cc Subject: Re: [PATCH net-next v3 1/2] net: micrel: Add support for lan8841 PHY > +#define LAN8841_MMD_TIMER_REG 0 > +#define LAN8841_MMD0_REGISTER_17 17 > +#define LAN8841_MMD0_REGISTER_17_DROP_OPT(x) ((x) & 0x3) > +#define LAN8841_MMD0_REGISTER_17_XMIT_TOG_TX_DIS BIT(3) > +#define LAN8841_OPERATION_MODE_STRAP_OVERRIDE_LOW_REG 2 > +#define LAN8841_OPERATION_MODE_STRAP_OVERRIDE_LOW_REG_MAGJACK BIT(14) > +#define LAN8841_MMD_ANALOG_REG 28 > +#define LAN8841_ANALOG_CONTROL_1 1 > +#define LAN8841_ANALOG_CONTROL_1_PLL_TRIM(x) (((x) & 0x3) << 5) > +#define LAN8841_ANALOG_CONTROL_10 13 > +#define LAN8841_ANALOG_CONTROL_10_PLL_DIV(x) ((x) & 0x3) > +#define LAN8841_ANALOG_CONTROL_11 14 > +#define LAN8841_ANALOG_CONTROL_11_LDO_REF(x) (((x) & 0x7) << 12) > +#define LAN8841_TX_LOW_I_CH_C_D_POWER_MANAGMENT 69 > +#define LAN8841_TX_LOW_I_CH_C_D_POWER_MANAGMENT_VAL 0xbffc > +#define LAN8841_BTRX_POWER_DOWN 70 > +#define LAN8841_BTRX_POWER_DOWN_QBIAS_CH_A BIT(0) > +#define LAN8841_BTRX_POWER_DOWN_BTRX_CH_A BIT(1) > +#define LAN8841_BTRX_POWER_DOWN_QBIAS_CH_B BIT(2) > +#define LAN8841_BTRX_POWER_DOWN_BTRX_CH_B BIT(3) > +#define LAN8841_BTRX_POWER_DOWN_BTRX_CH_C BIT(5) > +#define LAN8841_BTRX_POWER_DOWN_BTRX_CH_D BIT(7) > +#define LAN8841_ADC_CHANNEL_MASK 198 > +static int lan8841_config_init(struct phy_device *phydev) > +{ > + int err; It would be good to add a blank line before the function. > + int ret; I don't think you need both err and ret. But i expect the compiler is optimising one of them out anyway. > + > +#define LAN8841_OUTPUT_CTRL 25 > +#define LAN8841_OUTPUT_CTRL_INT_BUFFER BIT(14) > +static int lan8841_config_intr(struct phy_device *phydev) > +{ Blank line again, it helpers make the functions stand out. > +#define LAN8841_OPERATION_MODE_STRAP_LOW_REGISTER 3 > +#define LAN8841_OPERATION_MODE_STRAP_LOW_REGISTER_STRAP_RGMII_EN BIT(0) > +static int lan8841_probe(struct phy_device *phydev) > +{ > + int err; ... Andrew
Powered by blists - more mailing lists