netdev - Re: [patch net] devlink: change port event netdev notifier from per-net to global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b667f787-6f1b-19c0-d980-dc9ba801932f@intel.com>
Date:   Mon, 6 Feb 2023 09:39:06 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>
Subject: Re: [patch net] devlink: change port event netdev notifier from
 per-net to global



On 2/6/2023 1:41 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Currently only the network namespace of devlink instance is monitored
> for port events. If netdev is moved to a different namespace and then
> unregistered, NETDEV_PRE_UNINIT is missed which leads to trigger
> following WARN_ON in devl_port_unregister().
> WARN_ON(devlink_port->type != DEVLINK_PORT_TYPE_NOTSET);
> 
> Fix this by changing the netdev notifier from per-net to global so no
> event is missed.
> 
> Fixes: 02a68a47eade ("net: devlink: track netdev with devlink_port assigned")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Seems reasonable.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>