netdev - Re: [PATCH net-next 0/6] mlxsw: Misc devlink changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a296797b-84b8-87e7-e266-08078c49b0a8@intel.com>
Date:   Mon, 6 Feb 2023 09:41:53 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Petr Machata <petrm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>, <netdev@...r.kernel.org>
CC:     Ido Schimmel <idosch@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        "Danielle Ratson" <danieller@...dia.com>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 0/6] mlxsw: Misc devlink changes



On 2/6/2023 7:39 AM, Petr Machata wrote:
> This patchset adjusts mlxsw to recent devlink changes in net-next.
> 
> Patch #1 removes a devl_param_driverinit_value_set() call that was
> unnecessary, but now additionally triggers a WARN_ON.
> 
> Patches #2-#4 are non-functional preparations for the following patches.
> 
> Patch #5 fixes a use-after-free that is triggered while changing network
> namespaces.
> 
> Patch #6 makes mlxsw consistent with netdevsim by having mlxsw register
> its devlink instance before its sub-objects. It helps us avoid a warning
> described in the commit message.
> 

The whole series makes sense to me :)

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Danielle Ratson (1):
>   mlxsw: spectrum: Remove pointless call to
>     devlink_param_driverinit_value_set()
> 
> Ido Schimmel (5):
>   mlxsw: spectrum_acl_tcam: Add missing mutex_destroy()
>   mlxsw: spectrum_acl_tcam: Make fini symmetric to init
>   mlxsw: spectrum_acl_tcam: Reorder functions to avoid forward
>     declarations
>   mlxsw: spectrum_acl_tcam: Move devlink param to TCAM code
>   mlxsw: core: Register devlink instance before sub-objects
> 
>  drivers/net/ethernet/mellanox/mlxsw/core.c    |  31 +--
>  drivers/net/ethernet/mellanox/mlxsw/core.h    |   2 -
>  .../net/ethernet/mellanox/mlxsw/spectrum.c    |  62 -----
>  .../net/ethernet/mellanox/mlxsw/spectrum.h    |   3 +-
>  .../ethernet/mellanox/mlxsw/spectrum_acl.c    |  21 +-
>  .../mellanox/mlxsw/spectrum_acl_tcam.c        | 244 +++++++++++-------
>  .../mellanox/mlxsw/spectrum_acl_tcam.h        |   5 -
>  7 files changed, 161 insertions(+), 207 deletions(-)
>