netdev - Re: [PATCH net] selftests: forwarding: lib: quote the sysctl values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fsbgcrz1.fsf@nvidia.com>
Date:   Wed, 8 Feb 2023 12:30:52 +0100
From:   Petr Machata <petrm@...dia.com>
To:     Hangbin Liu <liuhangbin@...il.com>
CC:     <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
        David Ahern <dsahern@...nel.org>,
        Petr Machata <petrm@...lanox.com>
Subject: Re: [PATCH net] selftests: forwarding: lib: quote the sysctl values


Hangbin Liu <liuhangbin@...il.com> writes:

> When set/restore sysctl value, we should quote the value as some keys
> may have multi values, e.g. net.ipv4.ping_group_range
>
> Fixes: f5ae57784ba8 ("selftests: forwarding: lib: Add sysctl_set(), sysctl_restore()")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Yep, makes sense.

Reviewed-by: Petr Machata <petrm@...dia.com>