netdev - Re: [PATCH v6 net-next 2/8] sfc: add devlink info support for ef100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+O0A5Bk/zWur76J@nanopsycho>
Date:   Wed, 8 Feb 2023 15:38:59 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     alejandro.lucero-palau@....com
Cc:     netdev@...r.kernel.org, linux-net-drivers@....com,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, habetsm.xilinx@...il.com,
        ecree.xilinx@...il.com, linux-doc@...r.kernel.org, corbet@....net,
        jiri@...dia.com
Subject: Re: [PATCH v6 net-next 2/8] sfc: add devlink info support for ef100

Wed, Feb 08, 2023 at 03:25:13PM CET, alejandro.lucero-palau@....com wrote:
>From: Alejandro Lucero <alejandro.lucero-palau@....com>

[..]


>+static int efx_devlink_info_get(struct devlink *devlink,
>+				struct devlink_info_req *req,
>+				struct netlink_ext_ack *extack)
>+{
>+	struct efx_devlink *devlink_private = devlink_priv(devlink);
>+	struct efx_nic *efx = devlink_private->efx;
>+	int rc;
>+
>+	/* Several different MCDI commands are used. We report first error
>+	 * through extack along with total number of errors. Specific error
>+	 * information via system messages.

I think you forgot to remove this comment.

With this nit fixed, free free to add:
Reviewed-by: Jiri Pirko <jiri@...dia.com>



>+	 */
>+	rc = efx_devlink_info_board_cfg(efx, req);
>+	if (rc) {
>+		NL_SET_ERR_MSG_MOD(extack, "Getting board info failed");
>+		return rc;
>+	}
>+	rc = efx_devlink_info_stored_versions(efx, req);
>+	if (rc) {
>+		NL_SET_ERR_MSG_MOD(extack, "Getting stored versions failed");
>+		return rc;
>+	}
>+	rc = efx_devlink_info_running_versions(efx, req);
>+	if (rc) {
>+		NL_SET_ERR_MSG_MOD(extack, "Getting running versions failed");
>+		return rc;
>+	}
>+
>+	return 0;
>+}
>+#endif

[..]