netdev - Re: [patch net-next 2/7] devlink: make sure driver does not read updated driverinit param before reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+UifNXg7HEZjD8V@corigine.com>
Date:   Thu, 9 Feb 2023 17:42:36 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, tariqt@...dia.com,
        saeedm@...dia.com, jacob.e.keller@...el.com, gal@...dia.com,
        kim.phillips@....com, moshe@...dia.com
Subject: Re: [patch net-next 2/7] devlink: make sure driver does not read
 updated driverinit param before reload

On Thu, Feb 09, 2023 at 04:43:03PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> The driverinit param purpose is to serve the driver during init/reload
> time to provide a value, either default or set by user.
> 
> Make sure that driver does not read value updated by user before the
> reload is performed. Hold the new value in a separate struct and switch
> it during reload.

I gather this is related to:

[patch net-next 6/7] devlink: allow to call
        devl_param_driverinit_value_get() without holding instance lock

Perhaps it is worth mentioning that here.

> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Irregardless, this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>