netdev - Re: [patch net-next 3/7] devlink: fix the name of value arg of devl_param_driverinit_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+Uio2ULqYj6jd4F@corigine.com>
Date:   Thu, 9 Feb 2023 17:43:15 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, tariqt@...dia.com,
        saeedm@...dia.com, jacob.e.keller@...el.com, gal@...dia.com,
        kim.phillips@....com, moshe@...dia.com
Subject: Re: [patch net-next 3/7] devlink: fix the name of value arg of
 devl_param_driverinit_value_get()

On Thu, Feb 09, 2023 at 04:43:04PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Probably due to copy-paste error, the name of the arg is "init_val"
> which is misleading, as the pointer is used to point to struct where to
> store the current value. Rename it to "val" and change the arg comment
> a bit on the way.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>