netdev - Re: [PATCH net-next] net/sched: fix error recovery in qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230210161600.grt472jhup6wfkbb@skbuf>
Date:   Fri, 10 Feb 2023 18:16:00 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org,
        eric.dumazet@...il.com,
        syzbot+d44d88f1d11e6ca8576b@...kaller.appspotmail.com,
        Kurt Kanzenbach <kurt@...utronix.de>
Subject: Re: [PATCH net-next] net/sched: fix error recovery in qdisc_create()

On Fri, Feb 10, 2023 at 03:26:05PM +0000, Eric Dumazet wrote:
> If TCA_STAB attribute is malformed, qdisc_get_stab() returns
> an error, and we end up calling ops->destroy() while ops->init()
> has not been called yet.
> 
> While we are at it, call qdisc_put_stab() after ops->destroy().
> 
> Fixes: 1f62879e3632 ("net/sched: make stab available before ops->init() call")
> Reported-by: syzbot+d44d88f1d11e6ca8576b@...kaller.appspotmail.com
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Vladimir Oltean <vladimir.oltean@....com>
> Cc: Kurt Kanzenbach <kurt@...utronix.de>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>