netdev - Re: [PATCH bpf] selftests/bpf: enable mptcp before testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f0a72ee-ec30-8c97-0285-6c53db3d4477@tessares.net>
Date:   Fri, 10 Feb 2023 17:22:24 +0100
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>,
        Felix Maurer <fmaurer@...hat.com>,
        Nicolas Rybowski <nicolas.rybowski@...sares.net>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH bpf] selftests/bpf: enable mptcp before testing

Hi Hangbin Liu,

On 10/02/2023 10:32, Hangbin Liu wrote:
> Some distros may not enable mptcp by default. Enable it before start the
> mptcp server. To use the {read/write}_int_sysctl() functions, I moved
> them to test_progs.c
> 
> Fixes: 8039d353217c ("selftests/bpf: Add MPTCP test base")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  .../testing/selftests/bpf/prog_tests/mptcp.c  | 15 ++++++-

Thank you for the patch!

The modifications linked to MPTCP look good to me.

But I don't think it is needed here: I maybe didn't look properly at
'bpf/test_progs.c' file but I think each program from 'prog_tests'
directory is executed in a dedicated netns, no?

I don't have an environment ready to validate that but if yes, it means
that on a "vanilla" kernel, net.mptcp.enabled sysctl knob should be set
to 1. In this case, this modification would be specific to these distros
patching MPTCP code to disable it by default. It might then be better to
add this patch next to the one disabling MPTCP by default, no? (or
revert it to have MPTCP available by default for the applications asking
for it :) )

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net