netdev - Re: [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230210112202.6a4d6b9f@kernel.org>
Date:   Fri, 10 Feb 2023 11:22:02 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Harsh Jain <h.jain@....com>
Cc:     <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <thomas.lendacky@....com>, <Raju.Rangoju@....com>,
        <Shyam-sundar.S-k@....com>, <harshjain.prof@...il.com>,
        <abhijit.gangurde@....com>, <puneet.gupta@....com>,
        <nikhil.agarwal@....com>, <tarak.reddy@....com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH  0/6] net: ethernet: efct Add x3 ethernet driver

On Fri, 10 Feb 2023 18:33:15 +0530 Harsh Jain wrote:
> This patch series adds new ethernet network driver for Alveo X3522[1].
> X3 is a low-latency NIC with an aim to deliver the lowest possible
> latency. It accelerates a range of diverse trading strategies
> and financial applications.

Please get this reviewed by people within AMD who know something 
about netdev. Ed, Martin, Alejandro, etc.. This driver seems to 
share similarities with SFC and you haven't even CCed them.

This pile a 23kLoC has the same issues the community has been 
raising in reviews of other drivers from your organization.
We don't have the resources to be engaging with badly behaving,
throw-the-code-over-the-wall-open-source vendors.