| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Feb 2023 11:32:57 +0800
From: kernel test robot <lkp@...el.com>
To: Harsh Jain <h.jain@....com>, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
thomas.lendacky@....com, Raju.Rangoju@....com,
Shyam-sundar.S-k@....com, harshjain.prof@...il.com,
abhijit.gangurde@....com, puneet.gupta@....com,
nikhil.agarwal@....com, tarak.reddy@....com, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Harsh Jain <h.jain@....com>
Subject: Re: [PATCH 6/6] net: ethernet: efct: Add maintainer, kconfig,
makefile
Hi Harsh,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master horms-ipvs/master linus/master v6.2-rc7 next-20230210]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Harsh-Jain/net-ethernet-efct-New-X3-net-driver/20230210-210711
patch link: https://lore.kernel.org/r/20230210130321.2898-7-h.jain%40amd.com
patch subject: [PATCH 6/6] net: ethernet: efct: Add maintainer, kconfig, makefile
config: mips-db1xxx_defconfig (https://download.01.org/0day-ci/archive/20230211/202302111128.JPr7UbtM-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/93ed306161ac0259bd72b14922a7f6af60b3748c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Harsh-Jain/net-ethernet-efct-New-X3-net-driver/20230210-210711
git checkout 93ed306161ac0259bd72b14922a7f6af60b3748c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/ethernet/amd/efct/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302111128.JPr7UbtM-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/net/ethernet/amd/efct/mcdi_functions.c: In function 'efct_mcdi_filter_table_probe':
>> drivers/net/ethernet/amd/efct/mcdi_functions.c:283:24: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
283 | table->entry = vzalloc(EFCT_MCDI_FILTER_TBL_ROWS *
| ^~~~~~~
| kvzalloc
>> drivers/net/ethernet/amd/efct/mcdi_functions.c:283:22: warning: assignment to 'struct <anonymous> *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
283 | table->entry = vzalloc(EFCT_MCDI_FILTER_TBL_ROWS *
| ^
drivers/net/ethernet/amd/efct/mcdi_functions.c: In function 'efct_mcdi_filter_table_remove':
>> drivers/net/ethernet/amd/efct/mcdi_functions.c:309:9: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
309 | vfree(table->entry);
| ^~~~~
| kfree
cc1: some warnings being treated as errors
vim +283 drivers/net/ethernet/amd/efct/mcdi_functions.c
83f06a5b784384c Harsh Jain 2023-02-10 267
83f06a5b784384c Harsh Jain 2023-02-10 268 int efct_mcdi_filter_table_probe(struct efct_nic *efct)
83f06a5b784384c Harsh Jain 2023-02-10 269 {
83f06a5b784384c Harsh Jain 2023-02-10 270 struct efct_mcdi_filter_table *table;
83f06a5b784384c Harsh Jain 2023-02-10 271 int rc = 0, i;
83f06a5b784384c Harsh Jain 2023-02-10 272
83f06a5b784384c Harsh Jain 2023-02-10 273 if (efct->filter_table) /* already probed */
83f06a5b784384c Harsh Jain 2023-02-10 274 return rc;
83f06a5b784384c Harsh Jain 2023-02-10 275
83f06a5b784384c Harsh Jain 2023-02-10 276 table = kzalloc(sizeof(*table), GFP_KERNEL);
83f06a5b784384c Harsh Jain 2023-02-10 277 if (!table)
83f06a5b784384c Harsh Jain 2023-02-10 278 return -ENOMEM;
83f06a5b784384c Harsh Jain 2023-02-10 279
83f06a5b784384c Harsh Jain 2023-02-10 280 efct->filter_table = table;
83f06a5b784384c Harsh Jain 2023-02-10 281
83f06a5b784384c Harsh Jain 2023-02-10 282 init_rwsem(&table->lock);
83f06a5b784384c Harsh Jain 2023-02-10 @283 table->entry = vzalloc(EFCT_MCDI_FILTER_TBL_ROWS *
83f06a5b784384c Harsh Jain 2023-02-10 284 sizeof(*table->entry));
83f06a5b784384c Harsh Jain 2023-02-10 285 if (!table->entry) {
83f06a5b784384c Harsh Jain 2023-02-10 286 rc = -ENOMEM;
83f06a5b784384c Harsh Jain 2023-02-10 287 return rc;
83f06a5b784384c Harsh Jain 2023-02-10 288 }
83f06a5b784384c Harsh Jain 2023-02-10 289
83f06a5b784384c Harsh Jain 2023-02-10 290 for (i = 0; i < EFCT_MCDI_FILTER_TBL_ROWS; i++) {
83f06a5b784384c Harsh Jain 2023-02-10 291 table->entry[i].handle = EFCT_HANDLE_INVALID;
83f06a5b784384c Harsh Jain 2023-02-10 292 table->entry[i].ref_cnt = 0;
83f06a5b784384c Harsh Jain 2023-02-10 293 }
83f06a5b784384c Harsh Jain 2023-02-10 294
83f06a5b784384c Harsh Jain 2023-02-10 295 return rc;
83f06a5b784384c Harsh Jain 2023-02-10 296 }
83f06a5b784384c Harsh Jain 2023-02-10 297
83f06a5b784384c Harsh Jain 2023-02-10 298 void efct_mcdi_filter_table_remove(struct efct_nic *efct)
83f06a5b784384c Harsh Jain 2023-02-10 299 {
83f06a5b784384c Harsh Jain 2023-02-10 300 struct efct_mcdi_filter_table *table = efct->filter_table;
83f06a5b784384c Harsh Jain 2023-02-10 301 int i;
83f06a5b784384c Harsh Jain 2023-02-10 302
83f06a5b784384c Harsh Jain 2023-02-10 303 if (!table)
83f06a5b784384c Harsh Jain 2023-02-10 304 return;
83f06a5b784384c Harsh Jain 2023-02-10 305 for (i = 0; i < EFCT_MCDI_FILTER_TBL_ROWS; i++) {
83f06a5b784384c Harsh Jain 2023-02-10 306 if (table->entry[i].spec)
83f06a5b784384c Harsh Jain 2023-02-10 307 kfree((struct efct_filter_spec *)table->entry[i].spec);
83f06a5b784384c Harsh Jain 2023-02-10 308 }
83f06a5b784384c Harsh Jain 2023-02-10 @309 vfree(table->entry);
83f06a5b784384c Harsh Jain 2023-02-10 310 table->entry = NULL;
83f06a5b784384c Harsh Jain 2023-02-10 311 efct->filter_table = NULL;
83f06a5b784384c Harsh Jain 2023-02-10 312 kfree(table);
83f06a5b784384c Harsh Jain 2023-02-10 313 }
83f06a5b784384c Harsh Jain 2023-02-10 314
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists