netdev - Re: [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230209221906.6a69c79f@kernel.org>
Date:   Thu, 9 Feb 2023 22:19:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oz Shlomo <ozsh@...dia.com>
Cc:     <netdev@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>,
        Roi Dayan <roid@...dia.com>, "Jiri Pirko" <jiri@...dia.com>,
        Marcelo Ricardo Leitner <mleitner@...hat.com>,
        "Simon Horman" <simon.horman@...igine.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH  net-next v3 2/9] net/sched: act_pedit, setup offload
 action for action stats query

On Mon, 6 Feb 2023 15:54:35 +0200 Oz Shlomo wrote:
> +		for (k = 1; k < tcf_pedit_nkeys(act); k++) {
> +			last_cmd = cmd;
> +			cmd = tcf_pedit_cmd(act, k);
> +
> +			if (cmd != last_cmd) {
> +				NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
> +				return -EOPNOTSUPP;
> +			}

Is there a reason you're comparing to previous and not just always 
to the first one - since they all must be the same?