[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f49cc7a1-f873-b6a3-9654-16a7a662dad7@nvidia.com>
Date: Sun, 12 Feb 2023 13:33:24 +0200
From: Oz Shlomo <ozsh@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
Roi Dayan <roid@...dia.com>, Jiri Pirko <jiri@...dia.com>,
Marcelo Ricardo Leitner <mleitner@...hat.com>,
Simon Horman <simon.horman@...igine.com>,
Baowen Zheng <baowen.zheng@...igine.com>,
Jamal Hadi Salim <jhs@...atatu.com>,
Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload
action for action stats query
On 10/02/2023 8:19, Jakub Kicinski wrote:
> On Mon, 6 Feb 2023 15:54:35 +0200 Oz Shlomo wrote:
>> + for (k = 1; k < tcf_pedit_nkeys(act); k++) {
>> + last_cmd = cmd;
>> + cmd = tcf_pedit_cmd(act, k);
>> +
>> + if (cmd != last_cmd) {
>> + NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
>> + return -EOPNOTSUPP;
>> + }
> Is there a reason you're comparing to previous and not just always
> to the first one - since they all must be the same?
That can be done.
I will send a new version.
Powered by blists - more mailing lists