netdev - Re: [PATCH v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2023 09:49:49 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Eelco Chaudron <echaudro@...hat.com>
Cc:     Hangyu Hua <hbh25y@...il.com>, pshelar@....org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, xiangxia.m.yue@...il.com,
        netdev@...r.kernel.org, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: openvswitch: fix possible memory leak in
 ovs_meter_cmd_set()

On Fri, Feb 10, 2023 at 08:35:50AM +0100, Eelco Chaudron wrote:
> 
> 
> On 10 Feb 2023, at 3:05, Hangyu Hua wrote:
> 
> > old_meter needs to be free after it is detached regardless of whether
> > the new meter is successfully attached.
> >
> > Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters supported number")
> > Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> 
> Thanks for doing a v3. The change looks good to me!
> 
> Acked-by: Eelco Chaudron <echaudro@...hat.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>