[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d0a600842a1d4c289ef2414c4415095c@realtek.com>
Date: Mon, 13 Feb 2023 02:50:28 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Sascha Hauer <s.hauer@...gutronix.de>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC: Neo Jou <neojou@...il.com>, Hans Ulli Kroll <linux@...i-kroll.de>,
Yan-Hsuan Chuang <tony0620emma@...il.com>,
Kalle Valo <kvalo@...nel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Martin Blumenstingl" <martin.blumenstingl@...glemail.com>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
Alexander Hochbaum <alex@...udo.com>,
Da Xue <da@...re.computer>, Bernie Huang <phhuang@...ltek.com>,
Andreas Henriksson <andreas@...al.se>,
Viktor Petrenko <g0000ga@...il.com>
Subject: RE: [PATCH v2 1/3] wifi: rtw88: usb: Set qsel correctly
> -----Original Message-----
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Friday, February 10, 2023 7:17 PM
> To: linux-wireless@...r.kernel.org
> Cc: Neo Jou <neojou@...il.com>; Hans Ulli Kroll <linux@...i-kroll.de>; Ping-Ke Shih <pkshih@...ltek.com>;
> Yan-Hsuan Chuang <tony0620emma@...il.com>; Kalle Valo <kvalo@...nel.org>; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Martin Blumenstingl <martin.blumenstingl@...glemail.com>;
> kernel@...gutronix.de; Alexander Hochbaum <alex@...udo.com>; Da Xue <da@...re.computer>; Bernie Huang
> <phhuang@...ltek.com>; Andreas Henriksson <andreas@...al.se>; Viktor Petrenko <g0000ga@...il.com>; Sascha
> Hauer <s.hauer@...gutronix.de>
> Subject: [PATCH v2 1/3] wifi: rtw88: usb: Set qsel correctly
>
> We have to extract qsel from the skb before doing skb_push() on it,
> otherwise qsel will always be 0.
>
> Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>
> ---
> drivers/net/wireless/realtek/rtw88/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index 4ef38279b64c9..d9e995544e405 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -471,9 +471,9 @@ static int rtw_usb_tx_write(struct rtw_dev *rtwdev,
> u8 *pkt_desc;
> int ep;
>
> + pkt_info->qsel = rtw_usb_tx_queue_mapping_to_qsel(skb);
> pkt_desc = skb_push(skb, chip->tx_pkt_desc_sz);
> memset(pkt_desc, 0, chip->tx_pkt_desc_sz);
> - pkt_info->qsel = rtw_usb_tx_queue_mapping_to_qsel(skb);
> ep = qsel_to_ep(rtwusb, pkt_info->qsel);
> rtw_tx_fill_tx_desc(pkt_info, skb);
> rtw_tx_fill_txdesc_checksum(rtwdev, pkt_info, skb->data);
> --
> 2.30.2
Powered by blists - more mailing lists