netdev - RE: [PATCH v2 2/3] wifi: rtw88: usb: send Zero length packets if necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85afc4d7391e4585a02bd36b71ec4db3@realtek.com>
Date:   Mon, 13 Feb 2023 02:51:22 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC:     Neo Jou <neojou@...il.com>, Hans Ulli Kroll <linux@...i-kroll.de>,
        Yan-Hsuan Chuang <tony0620emma@...il.com>,
        Kalle Valo <kvalo@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Martin Blumenstingl" <martin.blumenstingl@...glemail.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Alexander Hochbaum <alex@...udo.com>,
        Da Xue <da@...re.computer>, Bernie Huang <phhuang@...ltek.com>,
        Andreas Henriksson <andreas@...al.se>,
        Viktor Petrenko <g0000ga@...il.com>
Subject: RE: [PATCH v2 2/3] wifi: rtw88: usb: send Zero length packets if necessary



> -----Original Message-----
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Friday, February 10, 2023 7:17 PM
> To: linux-wireless@...r.kernel.org
> Cc: Neo Jou <neojou@...il.com>; Hans Ulli Kroll <linux@...i-kroll.de>; Ping-Ke Shih <pkshih@...ltek.com>;
> Yan-Hsuan Chuang <tony0620emma@...il.com>; Kalle Valo <kvalo@...nel.org>; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Martin Blumenstingl <martin.blumenstingl@...glemail.com>;
> kernel@...gutronix.de; Alexander Hochbaum <alex@...udo.com>; Da Xue <da@...re.computer>; Bernie Huang
> <phhuang@...ltek.com>; Andreas Henriksson <andreas@...al.se>; Viktor Petrenko <g0000ga@...il.com>; Sascha
> Hauer <s.hauer@...gutronix.de>
> Subject: [PATCH v2 2/3] wifi: rtw88: usb: send Zero length packets if necessary
> 
> Zero length packets are necessary when sending URBs with size
> multiple of bulkout_size, otherwise the hardware just stalls.
> 
> Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw88/usb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index d9e995544e405..1a09c9288198a 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -271,6 +271,7 @@ static int rtw_usb_write_port(struct rtw_dev *rtwdev, u8 qsel, struct sk_buff *s
>  		return -ENOMEM;
> 
>  	usb_fill_bulk_urb(urb, usbd, pipe, skb->data, skb->len, cb, context);
> +	urb->transfer_flags |= URB_ZERO_PACKET;
>  	ret = usb_submit_urb(urb, GFP_ATOMIC);
> 
>  	usb_free_urb(urb);
> --
> 2.30.2