netdev - Re: [PATCH net-next 01/10] devlink: Split out health reporter create code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230213221712.3f91f288@kernel.org>
Date:   Mon, 13 Feb 2023 22:17:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Moshe Shemesh <moshe@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...dia.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 01/10] devlink: Split out health reporter
 create code

On Mon, 13 Feb 2023 15:14:09 +0200 Moshe Shemesh wrote:
> +/**
> + *	devl_port_health_reporter_create - create devlink health reporter for
> + *	                                   specified port instance
> + *
> + *	@port: devlink_port which should contain the new reporter
> + *	@ops: ops
> + *	@graceful_period: to avoid recovery loops, in msecs
> + *	@priv: priv
> + */

Can we drop or touch-up the kdoc as we move?

The indent should just use a space, not a tab.
() after function name

@port: devlink_port to which the health reports will relate
@ops: driver health reporter ops
@graceful_period: min time between recovery attempts
@priv: driver priv pointer