netdev - Re: [patch net-next v2] devlink: don't allow to change net namespace for FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230213221311.43d98ba8@kernel.org>
Date:   Mon, 13 Feb 2023 22:13:11 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, jacob.e.keller@...el.com, moshe@...dia.com,
        simon.horman@...igine.com
Subject: Re: [patch net-next v2] devlink: don't allow to change net
 namespace for FW_ACTIVATE reload action

On Mon, 13 Feb 2023 12:58:36 +0100 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> The change on network namespace only makes sense during re-init reload
> action. For FW activation it is not applicable. So check if user passed
> an ATTR indicating network namespace change request and forbid it.
> 
> Fixes: ccdf07219da6 ("devlink: Add reload action option to devlink reload command")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

The fixes tag needs to go, too, in that case. Otherwise stable will
likely suck it in. Which is riskier than putting it into an -rc.
No need to repost tho, we can drop the tag when applying.

Acked-by: Jakub Kicinski <kuba@...nel.org>