netdev - Re: [patch net-next v2] devlink: don't allow to change net namespace for FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+s44M7Qd2Two55y@nanopsycho>
Date:   Tue, 14 Feb 2023 08:31:44 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, jacob.e.keller@...el.com, moshe@...dia.com,
        simon.horman@...igine.com
Subject: Re: [patch net-next v2] devlink: don't allow to change net namespace
 for FW_ACTIVATE reload action

Tue, Feb 14, 2023 at 07:13:11AM CET, kuba@...nel.org wrote:
>On Mon, 13 Feb 2023 12:58:36 +0100 Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> The change on network namespace only makes sense during re-init reload
>> action. For FW activation it is not applicable. So check if user passed
>> an ATTR indicating network namespace change request and forbid it.
>> 
>> Fixes: ccdf07219da6 ("devlink: Add reload action option to devlink reload command")
>> Signed-off-by: Jiri Pirko <jiri@...dia.com>
>
>The fixes tag needs to go, too, in that case. Otherwise stable will
>likely suck it in. Which is riskier than putting it into an -rc.
>No need to repost tho, we can drop the tag when applying.

Okay, up to you. Thanks!

>
>Acked-by: Jakub Kicinski <kuba@...nel.org>