lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202302162052.Pm80BWt6-lkp@intel.com> Date: Thu, 16 Feb 2023 21:06:55 +0800 From: kernel test robot <lkp@...el.com> To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org Cc: oe-kbuild-all@...ts.linux.dev, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH net-next 1/2] net: make default_rps_mask a per netns attribute Hi Paolo, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Abeni/net-make-default_rps_mask-a-per-netns-attribute/20230216-023751 patch link: https://lore.kernel.org/r/35bde791a3fd775f0a027bba04a549233b705494.1676484775.git.pabeni%40redhat.com patch subject: [PATCH net-next 1/2] net: make default_rps_mask a per netns attribute config: parisc-defconfig (https://download.01.org/0day-ci/archive/20230216/202302162052.Pm80BWt6-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7b0e8effb3c7ac131c0da6e37cc33322ff22e2e3 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Paolo-Abeni/net-make-default_rps_mask-a-per-netns-attribute/20230216-023751 git checkout 7b0e8effb3c7ac131c0da6e37cc33322ff22e2e3 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@...el.com> | Link: https://lore.kernel.org/oe-kbuild-all/202302162052.Pm80BWt6-lkp@intel.com/ All errors (new ones prefixed by >>): net/core/sysctl_net_core.c: In function 'rps_default_mask_cow_alloc': >> net/core/sysctl_net_core.c:85:33: error: passing argument 1 of 'zalloc_cpumask_var' from incompatible pointer type [-Werror=incompatible-pointer-types] 85 | if (!zalloc_cpumask_var(&rps_default_mask, GFP_KERNEL)) | ^~~~~~~~~~~~~~~~~ | | | struct cpumask ** In file included from include/linux/smp.h:13, from include/linux/lockdep.h:14, from include/linux/spinlock.h:63, from include/linux/debugobjects.h:6, from include/linux/timer.h:8, from include/linux/workqueue.h:9, from include/linux/bpf.h:10, from include/linux/filter.h:9, from net/core/sysctl_net_core.c:9: include/linux/cpumask.h:897:54: note: expected 'struct cpumask (*)[1]' but argument is of type 'struct cpumask **' 897 | static inline bool zalloc_cpumask_var(cpumask_var_t *mask, gfp_t flags) | ~~~~~~~~~~~~~~~^~~~ cc1: some warnings being treated as errors vim +/zalloc_cpumask_var +85 net/core/sysctl_net_core.c 77 78 static struct cpumask *rps_default_mask_cow_alloc(struct net *net) 79 { 80 struct cpumask *rps_default_mask; 81 82 if (net->core.rps_default_mask) 83 return net->core.rps_default_mask; 84 > 85 if (!zalloc_cpumask_var(&rps_default_mask, GFP_KERNEL)) 86 return NULL; 87 88 /* pairs with READ_ONCE in rx_queue_default_mask() */ 89 WRITE_ONCE(net->core.rps_default_mask, rps_default_mask); 90 return rps_default_mask; 91 } 92 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Powered by blists - more mailing lists