lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <34e0f928109507b07b7cfe3f0a6eb9201015acf0.camel@redhat.com> Date: Thu, 16 Feb 2023 16:00:12 +0100 From: Paolo Abeni <pabeni@...hat.com> To: Gal Pressman <gal@...dia.com>, Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Tariq Toukan <tariqt@...dia.com> Subject: Re: [PATCH net-next 2/2] skbuff: Add likely to skb pointer in build_skb() On Thu, 2023-02-16 at 16:55 +0200, Gal Pressman wrote: > On 16/02/2023 1:01, Jakub Kicinski wrote: > > On Wed, 15 Feb 2023 14:17:07 +0200 Gal Pressman wrote: > > > - if (skb && frag_size) { > > > + if (likely(skb) && frag_size) { > > > > Should frag_size also be inside the likely? > > See the warning in __build_skb_around(). > > Agree, thanks Jakub and Paolo. > > Do you want to fix it up when you take the patch, or should I submit a v2? The way to address even such small changes is via re-submissions, please send a v2, thanks! Paolo
Powered by blists - more mailing lists