lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <646f4e37-9020-a5af-ba02-9962afa96d08@nvidia.com> Date: Thu, 16 Feb 2023 16:55:45 +0200 From: Gal Pressman <gal@...dia.com> To: Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Tariq Toukan <tariqt@...dia.com> Subject: Re: [PATCH net-next 2/2] skbuff: Add likely to skb pointer in build_skb() On 16/02/2023 1:01, Jakub Kicinski wrote: > On Wed, 15 Feb 2023 14:17:07 +0200 Gal Pressman wrote: >> - if (skb && frag_size) { >> + if (likely(skb) && frag_size) { > > Should frag_size also be inside the likely? > See the warning in __build_skb_around(). Agree, thanks Jakub and Paolo. Do you want to fix it up when you take the patch, or should I submit a v2?
Powered by blists - more mailing lists