lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y+5D6VW7FMrYKSE+@boxer> Date: Thu, 16 Feb 2023 15:55:37 +0100 From: Maciej Fijalkowski <maciej.fijalkowski@...el.com> To: Saeed Mahameed <saeed@...nel.org> CC: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Saeed Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com> Subject: Re: [net-next 1/9] net/mlx5e: Switch to using napi_build_skb() On Wed, Feb 15, 2023 at 04:09:10PM -0800, Saeed Mahameed wrote: > From: Tariq Toukan <tariqt@...dia.com> > > Use napi_build_skb() which uses NAPI percpu caches to obtain > skbuff_head instead of inplace allocation. > > napi_build_skb() calls napi_skb_cache_get(), which returns a cached > skb, or allocates a bulk of NAPI_SKB_CACHE_BULK (16) if cache is empty. > > Performance test: > TCP single stream, single ring, single core, default MTU (1500B). > > Before: 26.5 Gbits/sec > After: 30.1 Gbits/sec (+13.6%) Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com> > > Signed-off-by: Tariq Toukan <tariqt@...dia.com> > Reviewed-by: Gal Pressman <gal@...dia.com> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > index a9473a51edc1..9ac2c7778b5b 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > @@ -1556,7 +1556,7 @@ struct sk_buff *mlx5e_build_linear_skb(struct mlx5e_rq *rq, void *va, > u32 frag_size, u16 headroom, > u32 cqe_bcnt, u32 metasize) > { > - struct sk_buff *skb = build_skb(va, frag_size); > + struct sk_buff *skb = napi_build_skb(va, frag_size); > > if (unlikely(!skb)) { > rq->stats->buff_alloc_err++; > -- > 2.39.1 >
Powered by blists - more mailing lists