netdev - Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+5G/yc7UB+ahylb@lunn.ch>
Date:   Thu, 16 Feb 2023 16:08:47 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Yuiko Oshino <yuiko.oshino@...rochip.com>
Cc:     enguerrand.de-ribaucourt@...oirfairelinux.com,
        woojung.huh@...rochip.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
        UNGLinuxDriver@...rochip.com, linux@...linux.org.uk,
        edumazet@...gle.com, linux-usb@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's
 internal phy specific registers from the MAC driver

On Thu, Feb 16, 2023 at 07:20:53AM -0700, Yuiko Oshino wrote:
> Move the LAN7800 internal phy (phy ID  0x0007c132) specific register accesses to the phy driver (microchip.c).
> 
> Fixes: 14437e3fa284f465dbbc8611fd4331ca8d60e986 ("lan78xx: workaround of forced 100 Full/Half duplex mode error")

I would not say this is a fix which needs putting into stable. The
architecture is wrong to do it in the MAC driver, but i don't think it
causes real issues?

So please submit this to net-next, not net.

   Andrew