lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CH0PR11MB556166DDD69AD4D5FDCDB2F08EA09@CH0PR11MB5561.namprd11.prod.outlook.com> Date: Thu, 16 Feb 2023 15:20:33 +0000 From: <Yuiko.Oshino@...rochip.com> To: <andrew@...n.ch> CC: <enguerrand.de-ribaucourt@...oirfairelinux.com>, <Woojung.Huh@...rochip.com>, <hkallweit1@...il.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>, <davem@...emloft.net>, <UNGLinuxDriver@...rochip.com>, <linux@...linux.org.uk>, <edumazet@...gle.com>, <linux-usb@...r.kernel.org>, <kuba@...nel.org> Subject: RE: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver >-----Original Message----- >From: Andrew Lunn <andrew@...n.ch> >Sent: Thursday, February 16, 2023 10:09 AM >To: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com> >Cc: enguerrand.de-ribaucourt@...oirfairelinux.com; Woojung Huh - C21699 ><Woojung.Huh@...rochip.com>; hkallweit1@...il.com; netdev@...r.kernel.org; >pabeni@...hat.com; davem@...emloft.net; UNGLinuxDriver ><UNGLinuxDriver@...rochip.com>; linux@...linux.org.uk; >edumazet@...gle.com; linux-usb@...r.kernel.org; kuba@...nel.org >Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's >internal phy specific registers from the MAC driver > >EXTERNAL EMAIL: Do not click links or open attachments unless you know the >content is safe > >On Thu, Feb 16, 2023 at 07:20:53AM -0700, Yuiko Oshino wrote: >> Move the LAN7800 internal phy (phy ID 0x0007c132) specific register accesses >to the phy driver (microchip.c). >> >> Fixes: 14437e3fa284f465dbbc8611fd4331ca8d60e986 ("lan78xx: workaround >> of forced 100 Full/Half duplex mode error") > >I would not say this is a fix which needs putting into stable. The architecture is >wrong to do it in the MAC driver, but i don't think it causes real issues? > >So please submit this to net-next, not net. > > Andrew Hi Andrew, Enguerrand reported the below on 20 Dec 2022, therefore, submitting to net. " Some operations during the cable switch workaround modify the register LAN88XX_INT_MASK of the PHY. However, this register is specific to the LAN8835 PHY. For instance, if a DP8322I PHY is connected to the LAN7801, that register (0x19), corresponds to the LED and MAC address configuration, resulting in unapropriate behavior." Thank you. Yuiko
Powered by blists - more mailing lists