netdev - Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+5gOxDuyK3csyre@lunn.ch>
Date:   Thu, 16 Feb 2023 17:56:27 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Yuiko.Oshino@...rochip.com
Cc:     enguerrand.de-ribaucourt@...oirfairelinux.com,
        Woojung.Huh@...rochip.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
        UNGLinuxDriver@...rochip.com, linux@...linux.org.uk,
        edumazet@...gle.com, linux-usb@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's
 internal phy specific registers from the MAC driver

> Hi Andrew,
> 
> Enguerrand reported the below on 20 Dec 2022, therefore, submitting to net.
> 
> " Some operations during the cable switch workaround modify the register
> LAN88XX_INT_MASK of the PHY. However, this register is specific to the
> LAN8835 PHY. For instance, if a DP8322I PHY is connected to the LAN7801,
> that register (0x19), corresponds to the LED and MAC address
> configuration, resulting in unapropriate behavior."

O.K.

So please include in the commit message this information. Then it
becomes clear it really is a fix.

Also, you did not add a fixes: tag to the second patch. There is a
danger the first patch gets back ported, but not the second. Since you
are just moving code around, i suggest you have just have one patch.

    Andrew