netdev - RE: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2023 18:30:51 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <andrew@...n.ch>
CC:     <enguerrand.de-ribaucourt@...oirfairelinux.com>,
        <Woojung.Huh@...rochip.com>, <hkallweit1@...il.com>,
        <netdev@...r.kernel.org>, <pabeni@...hat.com>,
        <davem@...emloft.net>, <UNGLinuxDriver@...rochip.com>,
        <linux@...linux.org.uk>, <edumazet@...gle.com>,
        <linux-usb@...r.kernel.org>, <kuba@...nel.org>
Subject: RE: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's
 internal phy specific registers from the MAC driver

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Thursday, February 16, 2023 11:56 AM
>To: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com>
>Cc: enguerrand.de-ribaucourt@...oirfairelinux.com; Woojung Huh - C21699
><Woojung.Huh@...rochip.com>; hkallweit1@...il.com; netdev@...r.kernel.org;
>pabeni@...hat.com; davem@...emloft.net; UNGLinuxDriver
><UNGLinuxDriver@...rochip.com>; linux@...linux.org.uk;
>edumazet@...gle.com; linux-usb@...r.kernel.org; kuba@...nel.org
>Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's
>internal phy specific registers from the MAC driver
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>> Hi Andrew,
>>
>> Enguerrand reported the below on 20 Dec 2022, therefore, submitting to net.
>>
>> " Some operations during the cable switch workaround modify the
>> register LAN88XX_INT_MASK of the PHY. However, this register is
>> specific to the
>> LAN8835 PHY. For instance, if a DP8322I PHY is connected to the
>> LAN7801, that register (0x19), corresponds to the LED and MAC address
>> configuration, resulting in unapropriate behavior."
>
>O.K.
>
>So please include in the commit message this information. Then it becomes clear it
>really is a fix.
>
>Also, you did not add a fixes: tag to the second patch. There is a danger the first
>patch gets back ported, but not the second. Since you are just moving code around,
>i suggest you have just have one patch.
>
>    Andrew

No problem.
One patch would be easier!
I will add the comment from Enguerrand.
I will do v2 tomorrow.

Thank you.
Yuiko