netdev - Re: [PATCH v2 0/3] can: esd_usb: Some more preparation for supporting esd CAN-USB/3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12296b28afc0848f1989d3eaab06946471de5077.camel@esd.eu>
Date:   Thu, 16 Feb 2023 18:36:21 +0000
From:   Frank Jungclaus <Frank.Jungclaus@....eu>
To:     "mkl@...gutronix.de" <mkl@...gutronix.de>
CC:     Stefan Mätje <Stefan.Maetje@....eu>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mailhol.vincent@...adoo.fr" <mailhol.vincent@...adoo.fr>
Subject: Re: [PATCH v2 0/3] can: esd_usb: Some more preparation for supporting
 esd CAN-USB/3

On Wed, 2023-02-15 at 09:52 +0100, Marc Kleine-Budde wrote:
> On 14.02.2023 17:02:20, Frank Jungclaus wrote:
> > Another small batch of patches to be seen as preparation for adding
> > support of the newly available esd CAN-USB/3 to esd_usb.c.
> > 
> > Due to some unresolved questions adding support for
> > CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> > patches.
> > 
> > *Resend of the whole series as v2 for easier handling.*
> 
> As Vincent pointed out in review of a completely different patch series,
> bu this applies here, too:
> 
> > For the titles, please use imperative (e.g. add) instead of past tense
> > (e.g. Added). This also applies to the description.
> 
> Further, the subject ob patches 1 and 2 can be improved a bit, e.g.
> patch 1 could mention to move the SJA1000_ECC_SEG for a specific reason.
> 
> regards,
> Marc
> 
Hi Marc, 
ok, I'll resend this series as v3 soon to address your comments.

Regards, Frank