lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y+5It7zl66IoeKj3@smile.fi.intel.com> Date: Thu, 16 Feb 2023 17:16:07 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Pawel Chmielewski <pawel.chmielewski@...el.com> Cc: Jonathan.Cameron@...wei.com, baohua@...nel.org, bristot@...hat.com, bsegall@...gle.com, davem@...emloft.net, dietmar.eggemann@....com, gal@...dia.com, gregkh@...uxfoundation.org, hca@...ux.ibm.com, jacob.e.keller@...el.com, jesse.brandeburg@...el.com, jgg@...dia.com, juri.lelli@...hat.com, kuba@...nel.org, leonro@...dia.com, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org, linux@...musvillemoes.dk, mgorman@...e.de, mingo@...hat.com, netdev@...r.kernel.org, peter@...jl.ca, peterz@...radead.org, rostedt@...dmis.org, saeedm@...dia.com, tariqt@...dia.com, tony.luck@...el.com, torvalds@...ux-foundation.org, ttoukan.linux@...il.com, vincent.guittot@...aro.org, vschneid@...hat.com, yury.norov@...il.com Subject: Re: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity masks On Thu, Feb 16, 2023 at 05:14:33PM +0200, Andy Shevchenko wrote: > On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote: ... > > + for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) { > > + if (v_idx >= vsi->num_q_vectors) > > > + goto out; > > Useless. You can return 0; here. > > > + } Btw, I briefly checked the other functions nearby in the code and none of them is using goto for OK cases. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists