[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+5IWLpC1uTaa4Ks@smile.fi.intel.com>
Date: Thu, 16 Feb 2023 17:14:32 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Pawel Chmielewski <pawel.chmielewski@...el.com>
Cc: Jonathan.Cameron@...wei.com, baohua@...nel.org, bristot@...hat.com,
bsegall@...gle.com, davem@...emloft.net, dietmar.eggemann@....com,
gal@...dia.com, gregkh@...uxfoundation.org, hca@...ux.ibm.com,
jacob.e.keller@...el.com, jesse.brandeburg@...el.com,
jgg@...dia.com, juri.lelli@...hat.com, kuba@...nel.org,
leonro@...dia.com, linux-crypto@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
linux@...musvillemoes.dk, mgorman@...e.de, mingo@...hat.com,
netdev@...r.kernel.org, peter@...jl.ca, peterz@...radead.org,
rostedt@...dmis.org, saeedm@...dia.com, tariqt@...dia.com,
tony.luck@...el.com, torvalds@...ux-foundation.org,
ttoukan.linux@...il.com, vincent.guittot@...aro.org,
vschneid@...hat.com, yury.norov@...il.com
Subject: Re: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity
masks
On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote:
> With the introduction of sched_numa_hop_mask() and for_each_numa_hop_mask(),
> the affinity masks for queue vectors can be conveniently set by preferring the
> CPUs that are closest to the NUMA node of the parent PCI device.
...
> + v_idx = 0;
> +
Redundant blank line.
> + for_each_numa_hop_mask(aff_mask, numa_node) {
> + for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) {
> + if (v_idx >= vsi->num_q_vectors)
> + goto out;
Useless. You can return 0; here.
> + if (cpu_online(cpu)) {
> + cpumask_set_cpu(cpu, &vsi->q_vectors[v_idx]->affinity_mask);
> + v_idx++;
> + }
> + }
> +
> + last_aff_mask = aff_mask;
> + }
> +
> +out:
> return 0;
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists