netdev - Re: [PATCH bpf-next] Fix typos in selftest/bpf files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4753a724-2fd4-3672-c7ce-0164fe759eea@infradead.org>
Date:   Thu, 16 Feb 2023 00:30:33 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Taichi Nishimura <awkrail01@...il.com>, andrii@...nel.org,
        mykolal@...com, ast@...nel.org, daniel@...earbox.net,
        martin.lau@...ux.dev, song@...nel.org, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
        haoluo@...gle.com, jolsa@...nel.org, shuah@...nel.org,
        davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
        nathan@...nel.org, ndesaulniers@...gle.com, trix@...hat.com,
        iii@...ux.ibm.com, ytcoode@...il.com, deso@...teo.net,
        memxor@...il.com, joannelkoong@...il.com
Cc:     bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH bpf-next] Fix typos in selftest/bpf files



On 2/16/23 00:04, Taichi Nishimura wrote:
> This patch is a re-submitting patch.
> I cloned bpf-next repo, run spell checker, and fixed typos.
> Included v1 and v2 patches to this one.
> 
> Could you review it again? 
> Let me know if I have any mistakes.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@...il.com>

Hi,
The corrections all look good.
Of course, you need to fix what Greg mentioned, then you can resubmit
the patch with this added:

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c  | 2 +-
>  tools/testing/selftests/bpf/prog_tests/trampoline_count.c   | 2 +-
>  .../testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
>  tools/testing/selftests/bpf/progs/dynptr_fail.c             | 2 +-
>  tools/testing/selftests/bpf/progs/strobemeta.h              | 2 +-
>  tools/testing/selftests/bpf/progs/test_cls_redirect.c       | 6 +++---
>  tools/testing/selftests/bpf/progs/test_subprogs.c           | 2 +-
>  tools/testing/selftests/bpf/progs/test_xdp_vlan.c           | 2 +-
>  tools/testing/selftests/bpf/test_cpp.cpp                    | 2 +-
>  tools/testing/selftests/bpf/veristat.c                      | 4 ++--
>  10 files changed, 13 insertions(+), 13 deletions(-)
> 


-- 
~Randy