netdev - Re: [PATCH net-next v1] ice: properly alloc ICE_VSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3489ad7f-36d1-2726-d99c-0060865d015c@intel.com>
Date:   Fri, 17 Feb 2023 15:49:49 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
CC:     <netdev@...r.kernel.org>, <kuba@...nel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <anthony.l.nguyen@...el.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH net-next v1] ice: properly alloc ICE_VSI_LB

From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Date: Fri, 17 Feb 2023 11:50:17 +0100

> Devlink reload patchset introduced regression. ICE_VSI_LB wasn't
> taken into account when doing default allocation. Fix it by adding a
> case for ICE_VSI_LB in ice_vsi_alloc_def().
> 
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Reported-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Too late for 'net-final' PR which did hit the main tree already and I
believe there won't be any more until 6.2 is out, so expect it in 6.2.1
only :s

> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 5e81f7ae252c..3c41ebfc23d8 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -627,6 +627,7 @@ ice_vsi_alloc_def(struct ice_vsi *vsi, struct ice_channel *ch)
>  		vsi->next_base_q = ch->base_q;
>  		break;
>  	case ICE_VSI_VF:
> +	case ICE_VSI_LB:
>  		break;
>  	default:
>  		ice_vsi_free_arrays(vsi);

Thanks,
Olek