netdev - Re: [PATCH bpf-next 1/2] net/smc: Introduce BPF injection capability for SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ff5ad40-7280-2060-4402-d3bada4ce200@linux.alibaba.com>
Date:   Tue, 21 Feb 2023 19:55:46 +0800
From:   "D. Wythe" <alibuda@...ux.alibaba.com>
To:     kernel test robot <lkp@...el.com>, kgraul@...ux.ibm.com,
        wenjia@...ux.ibm.com, jaka@...ux.ibm.com, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/2] net/smc: Introduce BPF injection capability
 for SMC


Thanks! I will repost a fixed patch.


On 2/21/23 7:30 PM, kernel test robot wrote:
> Hi Wythe,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on bpf-next/master]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/D-Wythe/net-smc-Introduce-BPF-injection-capability-for-SMC/20230221-155712
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> patch link:    https://lore.kernel.org/r/1676966191-47736-2-git-send-email-alibuda%40linux.alibaba.com
> patch subject: [PATCH bpf-next 1/2] net/smc: Introduce BPF injection capability for SMC
> config: i386-randconfig-a013-20230220 (https://download.01.org/0day-ci/archive/20230221/202302211908.BgagxpRo-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/intel-lab-lkp/linux/commit/e2b31aece49068d7a07ca4bbd5fbdbd92f45a25e
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review D-Wythe/net-smc-Introduce-BPF-injection-capability-for-SMC/20230221-155712
>          git checkout e2b31aece49068d7a07ca4bbd5fbdbd92f45a25e
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202302211908.BgagxpRo-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> net/smc/bpf_smc_struct_ops.c:61:33: error: use of undeclared identifier 'BTF_SMC_TYPE_MAX'; did you mean 'BTF_SMC_TYPE_SOCK'?
>     BTF_ID_LIST_GLOBAL(btf_smc_ids, BTF_SMC_TYPE_MAX)
>                                     ^~~~~~~~~~~~~~~~
>                                     BTF_SMC_TYPE_SOCK
>     include/linux/btf_ids.h:211:61: note: expanded from macro 'BTF_ID_LIST_GLOBAL'
>     #define BTF_ID_LIST_GLOBAL(name, n) u32 __maybe_unused name[n];
>                                                                 ^
>     include/linux/btf_ids.h:275:1: note: 'BTF_SMC_TYPE_SOCK' declared here
>     BTF_SMC_TYPE_xxx
>     ^
>     include/linux/btf_ids.h:269:15: note: expanded from macro 'BTF_SMC_TYPE_xxx'
>             BTF_SMC_TYPE(BTF_SMC_TYPE_SOCK, smc_sock)               \
>                          ^
>     1 error generated.
> 
> 
> vim +61 net/smc/bpf_smc_struct_ops.c
> 
>      59	
>      60	/* define global smc ID for smc_struct_ops */
>    > 61	BTF_ID_LIST_GLOBAL(btf_smc_ids, BTF_SMC_TYPE_MAX)
>      62	#define BTF_SMC_TYPE(name, type) BTF_ID(struct, type)
>      63	BTF_SMC_TYPE_xxx
>      64	#undef BTF_SMC_TYPE
>      65	
>