[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <89c3f9b68d8030270ad58af2d9c94ae43eb5b1e6.camel@redhat.com>
Date: Tue, 21 Feb 2023 12:57:29 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>
Cc: Russell King <rmk+kernel@...linux.org.uk>, kernel@...gutronix.de,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v2 2/4] net: phy: c45: add
genphy_c45_an_config_eee_aneg() function
On Tue, 2023-02-21 at 06:03 +0100, Oleksij Rempel wrote:
> Add new genphy_c45_an_config_eee_aneg() function and replace some of
> genphy_c45_write_eee_adv() calls. This will be needed by the next patch.
>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
> drivers/net/phy/phy-c45.c | 12 +++++++++++-
> drivers/net/phy/phy_device.c | 2 +-
> include/linux/phy.h | 1 +
> 3 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
> index f23cce2c5199..904f64818922 100644
> --- a/drivers/net/phy/phy-c45.c
> +++ b/drivers/net/phy/phy-c45.c
> @@ -262,7 +262,7 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev)
> linkmode_and(phydev->advertising, phydev->advertising,
> phydev->supported);
>
> - ret = genphy_c45_write_eee_adv(phydev, phydev->supported_eee);
> + ret = genphy_c45_an_config_eee_aneg(phydev);
> if (ret < 0)
> return ret;
> else if (ret)
> @@ -858,6 +858,16 @@ int genphy_c45_read_eee_abilities(struct phy_device *phydev)
> }
> EXPORT_SYMBOL_GPL(genphy_c45_read_eee_abilities);
>
> +/**
> + * genphy_c45_an_config_eee_aneg - write advertised EEE link modes
> + * @phydev: target phy_device struct
> + * @adv: the linkmode advertisement settings
This function does not have a second argument.
Cheers,
Paolo
Powered by blists - more mailing lists