netdev - Re: [PATCH ethtool] uapi: if.h: fix linux/libc-compat.h include on Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230224121051.GA7007@unicorn.suse.cz>
Date:   Fri, 24 Feb 2023 13:10:51 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Thomas Devoogdt <thomas@...oogdt.com>
Cc:     netdev@...r.kernel.org, Thomas Devoogdt <thomas.devoogdt@...co.com>
Subject: Re: [PATCH ethtool] uapi: if.h: fix linux/libc-compat.h include on
 Linux < 3.12

On Fri, Feb 24, 2023 at 11:05:43AM +0100, Thomas Devoogdt wrote:
> 
> I now remember (while looking at the other patches I had to add) that
> I'm also missing __kernel_sa_family_t from /uapi/linux/socket.h (for
> Linux < 3.7). So it's indeed not just libc-compat.h which is causing
> problems. So perhaps take that one along while at it.

At the moment, the full set to add would be

    linux/const.h
    linux/if_addr.h
    linux/if_ether.h
    linux/libc-compat.h
    linux/neighbour.h
    linux/posix_types.h
    linux/socket.h
    linux/stddef.h
    linux/types.h

It looks like a lot but maintaining the whole uapi subdirectory can be
fully scripted. Then I realized that there can be more than just linux/*
and updated the script to pull in everything found in exported kernel
headers. That added few more files:

    asm-generic/bitsperlong.h
    asm-generic/int-ll64.h
    asm-generic/types.h
    asm/bitsperlong.h
    asm/posix_types.h
    asm/types.h

This is a bit more tricky as asm/* are architecture dependent. I suppose
just taking x86_64 versions everywhere would be a bad idea for headers
defining types. So I guess we may either omit asm/ or both asm-generic/
and asm/. Neither is perfect and I'm not completely sure which option is
safer.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)