netdev - Re: [net 07/10] net/mlx5e: Correct SKB room check to use all room in the fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28ccadd6-7c79-2a18-315e-3eabb14db80e@linux.dev>
Date:   Fri, 24 Feb 2023 12:18:32 +0000
From:   Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To:     Jakub Kicinski <kuba@...nel.org>, Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [net 07/10] net/mlx5e: Correct SKB room check to use all room in
 the fifo

On 24/02/2023 00:38, Jakub Kicinski wrote:
> On Thu, 23 Feb 2023 14:52:44 -0800 Saeed Mahameed wrote:
>> From: Rahul Rameshbabu <rrameshbabu@...dia.com>
>>
>> Previous check was comparing against the fifo mask. The mask is size of the
>> fifo (power of two) minus one, so a less than or equal comparator should be
>> used for checking if the fifo has room for the SKB.
>>
>> Fixes: 19b43a432e3e ("net/mlx5e: Extend SKB room check to include PTP-SQ")
> 
> How big is the fifo? Not utilizing a single entry is not really worth
> calling a bug if the fifo has at least 32 entries..

AFAIK, it has the same size that any other SQ queue, up to 8192 entries 
for now.