lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <07ee8ccb-96c2-eb74-5c8d-65934dc051db@gmail.com> Date: Mon, 27 Feb 2023 10:23:45 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Rafał Miłecki <zajec5@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: Arnd Bergmann <arnd@...db.de>, Jon Mason <jon.mason@...adcom.com>, netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com, Rafał Miłecki <rafal@...ecki.pl>, Jon Mason <jdmason@...zu.us> Subject: Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 On 2/27/2023 1:11 AM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@...ecki.pl> > > While bringing hardware up we should perform a full reset including the > switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what > specification says and what reference driver does. > > This seems to be critical for the BCM5358. Without this hardware doesn't > get initialized properly and doesn't seem to transmit or receive any > packets. > > Originally bgmac was calling bgmac_chip_reset() before setting > "has_robosw" property which resulted in expected behaviour. That has > changed as a side effect of adding platform device support which > regressed BCM5358 support. > > Fixes: f6a95a24957a ("net: ethernet: bgmac: Add platform device support") > Cc: Jon Mason <jdmason@...zu.us> > Signed-off-by: Rafał Miłecki <rafal@...ecki.pl> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists