[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y/x91CqqRE1mLTWc@unreal>
Date: Mon, 27 Feb 2023 11:54:28 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Rafał Miłecki <zajec5@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
Florian Fainelli <f.fainelli@...il.com>,
Jon Mason <jon.mason@...adcom.com>, netdev@...r.kernel.org,
bcm-kernel-feedback-list@...adcom.com,
Rafał Miłecki <rafal@...ecki.pl>,
Jon Mason <jdmason@...zu.us>
Subject: Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358
On Mon, Feb 27, 2023 at 10:11:56AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
>
> While bringing hardware up we should perform a full reset including the
> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
> specification says and what reference driver does.
>
> This seems to be critical for the BCM5358. Without this hardware doesn't
> get initialized properly and doesn't seem to transmit or receive any
> packets.
>
> Originally bgmac was calling bgmac_chip_reset() before setting
> "has_robosw" property which resulted in expected behaviour. That has
> changed as a side effect of adding platform device support which
> regressed BCM5358 support.
>
> Fixes: f6a95a24957a ("net: ethernet: bgmac: Add platform device support")
> Cc: Jon Mason <jdmason@...zu.us>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 8 ++++++--
> drivers/net/ethernet/broadcom/bgmac.h | 2 ++
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists