netdev - Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support [multicast/DSA issues]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/0N4ZcUl8pG7awc@shell.armlinux.org.uk>
Date:   Mon, 27 Feb 2023 20:09:05 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Köry Maincent <kory.maincent@...tlin.com>,
        andrew@...n.ch, davem@...emloft.net, f.fainelli@...il.com,
        hkallweit1@...il.com, kuba@...nel.org, netdev@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support
 [multicast/DSA issues]

On Mon, Feb 27, 2023 at 11:45:58AM -0800, Richard Cochran wrote:
> On Mon, Feb 27, 2023 at 03:20:05PM +0000, Russell King (Oracle) wrote:
> 
> > Attempting to fix this problem was basically rejected by the PTP
> > maintainer, and thus we're at a deadlock over the issue, and Marvell
> > PHY PTP support can never be merged into mainline.
> 
> FWIW, here was my attempt to solve the issue by making the PHY/MAC
> layer selectable at run time, while preserving PHY as the default.
> 
> https://lore.kernel.org/netdev/20220103232555.19791-1-richardcochran@gmail.com/

Hi Richard,

Looking at that link, I'm only seeing that message, with none of
the patches nor the discussion. Digging back in my mailbox, I
find that the patches weren't threaded to the cover message, which
makes it quite difficult to go back and review the discussion.

Patch 1 (no comments)
https://lore.kernel.org/netdev/20220103232555.19791-2-richardcochran@gmail.com
Patch 2 (one comment from me suggesting moving a variable)
https://lore.kernel.org/netdev/20220103232555.19791-3-richardcochran@gmail.com
Patch 3 (lots of comments)
https://lore.kernel.org/netdev/20220103232555.19791-4-richardcochran@gmail.com
Patch 4 (no comments)
https://lore.kernel.org/netdev/20220103232555.19791-5-richardcochran@gmail.com

Looking back briefly at the discussion on patch 3, was the reason
this approach died due to the request to have something more flexible,
supporting multiple hardware timestamps per packet?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!