netdev - Re: [v2] wifi: brcmfmac: support CQM RSSI notification with older firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167749453809.25422.2426932954308893470.kvalo@kernel.org>
Date:   Mon, 27 Feb 2023 10:42:19 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     John Keeping <john@...anate.com>
Cc:     netdev@...r.kernel.org, John Keeping <john@...anate.com>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alvin Šipraga <ALSI@...g-olufsen.dk>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, linux-kernel@...r.kernel.org
Subject: Re: [v2] wifi: brcmfmac: support CQM RSSI notification with older
 firmware

John Keeping <john@...anate.com> wrote:

> Using the BCM4339 firmware from linux-firmware (version "BCM4339/2 wl0:
> Sep  5 2019 11:05:52 version 6.37.39.113 (r722271 CY)" from
> cypress/cyfmac4339-sdio.bin) the RSSI respose is only 4 bytes, which
> results in an error being logged.
> 
> It seems that older devices send only the RSSI field and neither SNR nor
> noise is included.  Handle this by accepting a 4 byte message and
> reading only the RSSI from it.
> 
> Fixes: 7dd56ea45a66 ("brcmfmac: add support for CQM RSSI notifications")
> Signed-off-by: John Keeping <john@...anate.com>

Patch applied to wireless-next.git, thanks.

ec52d77d0775 wifi: brcmfmac: support CQM RSSI notification with older firmware

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230124104248.2917465-1-john@metanate.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches