lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y/yLhHIjtdBzSpLu@google.com> Date: Mon, 27 Feb 2023 10:52:52 +0000 From: Lee Jones <lee@...nel.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Colin Foster <colin.foster@...advantage.com>, Maksim Kiselev <bigunclemax@...il.com>, Maxim Kochetkov <fido_max@...ox.ru>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk> Subject: Re: [PATCH net 3/3] net: mscc: ocelot: fix duplicate driver name error On Fri, 24 Feb 2023, Vladimir Oltean wrote: > When compiling a kernel which has both CONFIG_NET_DSA_MSCC_OCELOT_EXT > and CONFIG_MSCC_OCELOT_SWITCH enabled, the following error message will > be printed: > > [ 5.266588] Error: Driver 'ocelot-switch' is already registered, aborting... > > Rename the ocelot_ext.c driver to "ocelot-ext-switch" to avoid the name > duplication, and update the mfd_cell entry for its resources. > > Fixes: 3d7316ac81ac ("net: dsa: ocelot: add external ocelot switch control") > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> > --- > drivers/mfd/ocelot-core.c | 2 +- Acked-by: Lee Jones <lee@...nel.org> > drivers/net/dsa/ocelot/ocelot_ext.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c > index b0ff05c1759f..e1772ff00cad 100644 > --- a/drivers/mfd/ocelot-core.c > +++ b/drivers/mfd/ocelot-core.c > @@ -177,7 +177,7 @@ static const struct mfd_cell vsc7512_devs[] = { > .num_resources = ARRAY_SIZE(vsc7512_miim1_resources), > .resources = vsc7512_miim1_resources, > }, { > - .name = "ocelot-switch", > + .name = "ocelot-ext-switch", > .of_compatible = "mscc,vsc7512-switch", > .num_resources = ARRAY_SIZE(vsc7512_switch_resources), > .resources = vsc7512_switch_resources, > diff --git a/drivers/net/dsa/ocelot/ocelot_ext.c b/drivers/net/dsa/ocelot/ocelot_ext.c > index 14efa6387bd7..52b41db63a28 100644 > --- a/drivers/net/dsa/ocelot/ocelot_ext.c > +++ b/drivers/net/dsa/ocelot/ocelot_ext.c > @@ -149,7 +149,7 @@ MODULE_DEVICE_TABLE(of, ocelot_ext_switch_of_match); > > static struct platform_driver ocelot_ext_switch_driver = { > .driver = { > - .name = "ocelot-switch", > + .name = "ocelot-ext-switch", > .of_match_table = of_match_ptr(ocelot_ext_switch_of_match), > }, > .probe = ocelot_ext_probe, > -- > 2.34.1 > -- Lee Jones [李琼斯]
Powered by blists - more mailing lists