netdev - Re: [PATCH] xfrm: Allow transport-mode states with AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/yQ5O7wXgOSzt3Z@gauss3.secunet.de>
Date:   Mon, 27 Feb 2023 12:15:48 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     David George <David.George@...hos.com>,
        Sri Sakthi <srisakthi.s@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Srisakthi Subramaniam <Srisakthi.Subramaniam@...hos.com>,
        Vimal Agrawal <Vimal.Agrawal@...hos.com>
Subject: Re: [PATCH] xfrm: Allow transport-mode states with AF_UNSPEC selector

On Tue, Feb 21, 2023 at 01:54:00PM +0800, Herbert Xu wrote:
> On Tue, Feb 21, 2023 at 12:05:26PM +0800, Herbert Xu wrote:
> > 
> > OK I wasn't aware of this.  This definitely looks buggy.  We need
> > to fix this bogus check.
> 
> It looks like I actually added this bogus check :)
> 
> Does this patch work for you?
> 
> ---8<---
> xfrm state selectors are matched against the inner-most flow
> which can be of any address family.  Therefore middle states
> in nested configurations need to carry a wildcard selector in
> order to work at all.
> 
> However, this is currently forbidden for transport-mode states.
> 
> Fix this by removing the unnecessary check.
> 
> Fixes: 13996378e658 ("[IPSEC]: Rename mode to outer_mode and add inner_mode")
> Reported-by: David George <David.George@...hos.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Patch applied, thanks a lot Herbert!