netdev - Re: [PATCH] [net] add rx_otherhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230228123314.315ef444@kernel.org>
Date:   Tue, 28 Feb 2023 12:33:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     nick black <dankamongmen@...il.com>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jeffrey Ji <jeffreyji@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry

On Tue, 28 Feb 2023 08:08:59 -0500 nick black wrote:
> --- net/core/net-sysfs.c
> +++ net/core/net-sysfs.c
> @@ -714,6 +714,10 @@ NETSTAT_ENTRY(rx_compressed);
>  NETSTAT_ENTRY(tx_compressed);
>  NETSTAT_ENTRY(rx_nohandler);
>  

I'd skip the empty line here to make it clear that the comment pertains
to what's above it, otherwise people may miss it.

When reposting pls make a new thread (patchwork won't pick up patches
sent with Re: at all:
https://patchwork.kernel.org/project/netdevbpf/patch/Y/386wA5az1Yixyp@schwarzgerat.orthanc/

> +/* end of old stats -- new stats via rtnetlink only. we do not want
> + * more sysfs entries.
> + */