netdev - Re: [PATCH] [net] add rx_otherhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/386wA5az1Yixyp@schwarzgerat.orthanc>
Date:   Tue, 28 Feb 2023 08:08:59 -0500
From:   nick black <dankamongmen@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jeffrey Ji <jeffreyji@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry

We do not want to export any further stats via sysfs.
Applications ought be using netlink. Note this at the end
of the NETSTAT_ENTRIES.
---
 net/core/net-sysfs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git net/core/net-sysfs.c net/core/net-sysfs.c
index 15e3f4606b5f..c00a0f332a22 100644
--- net/core/net-sysfs.c
+++ net/core/net-sysfs.c
@@ -714,6 +714,10 @@ NETSTAT_ENTRY(rx_compressed);
 NETSTAT_ENTRY(tx_compressed);
 NETSTAT_ENTRY(rx_nohandler);
 
+/* end of old stats -- new stats via rtnetlink only. we do not want
+ * more sysfs entries.
+ */
+
 static struct attribute *netstat_attrs[] __ro_after_init = {
 	&dev_attr_rx_packets.attr,
 	&dev_attr_tx_packets.attr,
-- 
2.39.2