netdev - Re: [PATCH] [net] add rx_otherhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/36sjlV6dWonLhC@schwarzgerat.orthanc>
Date:   Tue, 28 Feb 2023 07:59:30 -0500
From:   nick black <dankamongmen@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jeffrey Ji <jeffreyji@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry

Jakub Kicinski left as an exercise for the reader:
> How about a banner before rx_otherhost_dropped? Maybe:
> 
> 	/* end of old stats -- new stats via rtnetlink only */

sounds good to me; I'll also annotate the sysfs documentation to
emphasize that netlink is recommended, and that new stats will
not be reflected there. from the perspective of an outsider like
myself, it just looks like this stat was missed.

i'll have a new patch for you shortly. thank you for your review!

-- 
nick black -=- https://www.nick-black.com
to make an apple pie from scratch,
you need first invent a universe.