netdev - Re: [RFC PATCH v2 net-next] sfc: support offloading TC VLAN push/pop actions to the MAE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/3C9Lsjx03qxRXo@gmail.com>
Date:   Tue, 28 Feb 2023 09:01:40 +0000
From:   Martin Habets <habetsm.xilinx@...il.com>
To:     Edward Cree <ecree.xilinx@...il.com>
Cc:     Simon Horman <simon.horman@...igine.com>, edward.cree@....com,
        netdev@...r.kernel.org, linux-net-drivers@....com, leon@...nel.org
Subject: Re: [RFC PATCH v2 net-next] sfc: support offloading TC VLAN push/pop
 actions to the MAE

On Mon, Feb 27, 2023 at 09:33:49PM +0000, Edward Cree wrote:
> On 24/02/2023 10:07, Simon Horman wrote:
> > On Thu, Feb 23, 2023 at 11:50:26PM +0000, edward.cree@....com wrote:
> >> +				NL_SET_ERR_MSG_MOD(extack, "More than two VLAN pops, or action order violated");
> > 
> > nit: I'm not sure if there is anything to be done about it,
> >      but checkpatch complains about ling lines here...
> 
> Yeah I don't think these can be helped.  Breaking up the
>  containing function (to reduce indent depth) would be
>  rather synthetic imho, most of it wouldn't even be able
>  to be shared with the decap and conntrack versions when
>  those get added.)

You can put the string on it's own line, i.e. align it under
extack. I think that will pacify checkpatch.

Martin

> 
> >> +			}
> >> +			tci = fa->vlan.vid & 0x0fff;
> >> +			tci |= fa->vlan.prio << 13;
> > 
> > nit: Maybe VLAN_PRIO_SHIFT and VLAN_VID_MASK can be used here.
> 
> Yep good suggestion, incorporated for v3.
> Thanks for the review.
> 
> -ed