netdev - Re: [RFC PATCH v2 net-next] sfc: support offloading TC VLAN push/pop actions to the MAE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a35e32a0-0520-ce60-5296-39f36b278b5a@gmail.com>
Date:   Mon, 27 Feb 2023 21:33:49 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Simon Horman <simon.horman@...igine.com>, edward.cree@....com
Cc:     netdev@...r.kernel.org, linux-net-drivers@....com,
        habetsm.xilinx@...il.com, leon@...nel.org
Subject: Re: [RFC PATCH v2 net-next] sfc: support offloading TC VLAN push/pop
 actions to the MAE

On 24/02/2023 10:07, Simon Horman wrote:
> On Thu, Feb 23, 2023 at 11:50:26PM +0000, edward.cree@....com wrote:
>> +				NL_SET_ERR_MSG_MOD(extack, "More than two VLAN pops, or action order violated");
> 
> nit: I'm not sure if there is anything to be done about it,
>      but checkpatch complains about ling lines here...

Yeah I don't think these can be helped.  Breaking up the
 containing function (to reduce indent depth) would be
 rather synthetic imho, most of it wouldn't even be able
 to be shared with the decap and conntrack versions when
 those get added.)

>> +			}
>> +			tci = fa->vlan.vid & 0x0fff;
>> +			tci |= fa->vlan.prio << 13;
> 
> nit: Maybe VLAN_PRIO_SHIFT and VLAN_VID_MASK can be used here.

Yep good suggestion, incorporated for v3.
Thanks for the review.

-ed